added documentation for symmetric_yaw_tolerance#827
added documentation for symmetric_yaw_tolerance#827sandeepdutta wants to merge 12 commits intoros-navigation:masterfrom
Conversation
configuration/index.rst
Outdated
| Advanced Topics | ||
| *************** | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
|
|
||
| packages/symmetric_yaw_tolerance.rst |
There was a problem hiding this comment.
I think instead, we should add this to the tuning guide as a subpage under a header for Symmetric Navigation https://docs.nav2.org/tuning/index.html
I'd make sure to mention loudly and prominently this ROSCon talk on the subject: https://vimeo.com/879000809. I don't think most users for bidirectional need the implementation you've suggested. His work makes Nav2 fully bidirectional in terms of motion in the planners / controllers for motion -- but does care about the final orientation. Yours is adding not caring about the goal completion orientation, which is a special subcase of that
There was a problem hiding this comment.
Moved section to tuning guide as suggested. Thank you for link to the video, I watched it.
I am using "Theta Star" planner, I found that by using this planner and MPPI controller with "PreferForwardCritic"
disabled and "PathAngleCritic" forward_preference = false, the robot moves in a very optimal way , it chooses
backwards or forwards depending on the current orientation and desired direction of travel, it was reorienting at the goal position , which this change fixes. In fact I am not sure why the path inversion (as described in the video) is required if the robot is truly bidirectional. Maybe I am missing something
addressed comments on PR
SteveMacenski
left a comment
There was a problem hiding this comment.
Please also add that link in for Guillaume's talk
configuration/packages/nav2_controller-plugins/simple_goal_checker.rst
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,155 @@ | |||
| .. _symmetric_yaw_tolerance_guide: | |||
There was a problem hiding this comment.
This page can be removed now, moved to tuning
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
…cker.rst Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
|
Hi Steve, |
|
@sandeepdutta yes, please see the open review comments :-) |
…vigation#828) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Sandeep Dutta <quark01@gmail.com>
Signed-off-by: Sandeep Dutta <quark01@gmail.com>
|
I will take over this as well: #837 |
Basic Info
Description of contribution in a few bullet points
Updated documentation for PR #5795 Symmetric Yaw Tolerance for
Symmetric robots which can arrive at goal in either orientation